Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drtii 1691 use live view data for api v1 requests #308

Merged
merged 7 commits into from
Dec 4, 2024

Conversation

richbirch
Copy link
Contributor

Migrate flight & queue API code from drt-v2
Update API code to read from the aggregated database

Copy link
Contributor

@ngu04 ngu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one !

import uk.gov.homeoffice.drt.ports.{PortCode, Queues}
import uk.gov.homeoffice.drt.routes.api.v1.QueueApiV1Routes.QueueJsonResponse
import uk.gov.homeoffice.drt.time.MilliDate.MillisSinceEpoch
import uk.gov.homeoffice.drt.time.{LocalDate, SDate, SDateLike, UtcDate}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UtcDate is not used

.map(QueueJsonResponse(start, end, slotSize, _))
}

def terminalMinutesByMinute[T <: MinuteLike[_, _]](minutes: Seq[T],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be private ?

import uk.gov.homeoffice.drt.ports.PortCode
import uk.gov.homeoffice.drt.ports.Queues.{EGate, EeaDesk, NonEeaDesk}
import uk.gov.homeoffice.drt.ports.Terminals.{T1, Terminal}
import uk.gov.homeoffice.drt.routes.api.v1.QueueApiV1Routes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused import QueueApiV1Routes , UtcDate , Future


val start: SDateLike = SDate("2024-10-15T12:00")
val end: SDateLike = SDate("2024-10-15T12:30")
val utcDate = start.toUtcDate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can adde return type

@richbirch richbirch merged commit cbedb05 into leader Dec 4, 2024
2 checks passed
@richbirch richbirch deleted the DRTII-1691-Use-live-view-data-for-API-v1-requests branch December 4, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants